Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[show/fgnhg.py] Fix whitespace issues #1211

Merged
merged 6 commits into from
Nov 4, 2020
Merged

[show/fgnhg.py] Fix whitespace issues #1211

merged 6 commits into from
Nov 4, 2020

Conversation

jleveque
Copy link
Contributor

@jleveque jleveque commented Nov 3, 2020

  • Replace tabs with spaces
  • Fix alignment
  • Remove trailing whitespace
  • Remove spaces where not necessary, add spaces where necessary
  • Reorganize imports per PEP8 standards

@jleveque
Copy link
Contributor Author

jleveque commented Nov 3, 2020

@kktheballer: Please review, and for future contributions, please ensure to use spaces instead of tabs.

@kktheballer
Copy link
Contributor

@jleveque Thank you so much for looking into the formatting and for making the changes. I will make sure to use spaces and watch out for unecessary whitespaces from now on.

I believe one of the checks has failed. Let me try and rerun that first.

@kktheballer
Copy link
Contributor

retest this please

@jleveque
Copy link
Contributor Author

jleveque commented Nov 4, 2020

@kktheballer: Looking at the test failure, it appears that there is no V6 info in the output, but it is expected. Do you have an idea why?

@kktheballer
Copy link
Contributor

kktheballer commented Nov 4, 2020

@jleveque Let me take a look. Oddly, the errors I see after retest look different from the errors I saw in the original errors of this #1211 PR.

(In the original PR everything was passing.. Looking into)

@kktheballer
Copy link
Contributor

retest this please

@lguohan
Copy link
Contributor

lguohan commented Nov 4, 2020

the unit tests failed. likely due to the refactoring.

@jleveque
Copy link
Contributor Author

jleveque commented Nov 4, 2020

the unit tests failed. likely due to the refactoring.

That's my assumption, also. @kktheballer: Can you please review my changes, and check if I over- or under-indented a section?

@lguohan lguohan merged commit 061f428 into sonic-net:master Nov 4, 2020
@jleveque jleveque deleted the tabs_to_spaces branch November 4, 2020 20:48
@kktheballer
Copy link
Contributor

@jleveque Thanks for the indentation fix commit. Yes, it appeared that the issue was with the indentation level at which the table was finally displaying values.

Will keep in mind about the formatting for next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants