-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[show/fgnhg.py] Fix whitespace issues #1211
Conversation
jleveque
commented
Nov 3, 2020
•
edited
Loading
edited
- Replace tabs with spaces
- Fix alignment
- Remove trailing whitespace
- Remove spaces where not necessary, add spaces where necessary
- Reorganize imports per PEP8 standards
@kktheballer: Please review, and for future contributions, please ensure to use spaces instead of tabs. |
@jleveque Thank you so much for looking into the formatting and for making the changes. I will make sure to use spaces and watch out for unecessary whitespaces from now on. I believe one of the checks has failed. Let me try and rerun that first. |
retest this please |
@kktheballer: Looking at the test failure, it appears that there is no V6 info in the output, but it is expected. Do you have an idea why? |
retest this please |
the unit tests failed. likely due to the refactoring. |
That's my assumption, also. @kktheballer: Can you please review my changes, and check if I over- or under-indented a section? |
@jleveque Thanks for the indentation fix commit. Yes, it appeared that the issue was with the indentation level at which the table was finally displaying values. Will keep in mind about the formatting for next time. |